change to dialect generator #691
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
===========================================
+ Coverage 21.66% 38.03% +16.36%
===========================================
Files 46 85 +39
Lines 8048 15896 +7848
===========================================
+ Hits 1744 6046 +4302
- Misses 6304 9850 +3546 ☔ View full report in Codecov by Sentry. |
src/mlir/Dialects/MPI.jl
Outdated
There was a problem hiding this comment.
FYI, there are still a few files with changes in permissions.
There was a problem hiding this comment.
thx, each time I format I have to change them. It seems some are 644 and some are 755. Now, all dialects files are 755. I don't know how CI set the permission.
There was a problem hiding this comment.
oh right that's probably from
Reactant.jl/.github/workflows/regenerate-mlir-bindings.yml
Lines 43 to 47 in 95f6074
rebase #660 & #447. @mofeing I messed up #660 so I open a new PR.
Several modifications:
result_toresultresult_layouts=nothing::Union{Attribute, Nothing}doesn't constraintresult_layoutsso change to :result_layouts::Union{Attribute, Nothing} =nothingEnumAttr: using Attr parsing (MLIR doesn't expose methods in C to easily construct arbitrary attribute) and discriminant.conv